Skip to main content

Hidden memory leaks in WinForm Apps


Dealing with memory leaks in .NET apps it is always a hard thing to do. While most of the time the GC does a great job freeing us to worry about memory management, there are some edge cases where we have to be very careful to not screw things up.

In this post I am going to show a common issue I see when doing code reviews on WinForm apps.
First, let’s take a look at this code and see what it is wrong with it.



As you can guess, the problem with the code above is that creates a memory leak ;). But why?
We are effectively disposing FrmFoo...

There are two issues with the following line,


The first one, the GC will never be able to collect the garbage created inside the anonymous function generated by the C# compiler to back the lambda expression attached to the control’s click event. Even when we are disposing the form, the object created by the C# compiler is rooted inside the scope of that function and cannot be destroyed; hence the memory leak.

The second one, we don’t have access from an outer scope to the delegate attached to the click event, so we cannot effectively remove it while disposing the form. Which is a good practice and almost no one does it (myself included).

For the last issue, I made an extension method that solves the problem, but the first one still remains....

This is a nice way to implement the same use case without introducing memory leaks.


I know this is a trivial example and the impact of memory issues is almost none, but be careful with these kind of stuff, usually, issues like these are really tough and takes a lot of time to deal with them.

Here, the list of tools I frequently use to work on performance/memory related issues.








Comments

Popular posts from this blog

Moving to Medium

It's been a long time since I want to give medium a try, and finally, I made some time to do it. To get started on the new platform, I'll be doing series on "Getting programming concepts, languages and tools". If it sounds interesting to you, please take a look at the first post  Getting AWK  and spread the word if you like it. I'm not going to migrate old entries to the new web site. They will remain here safe and sound! As usual, thanks for reading!

Working with unattended reports

In this post I‘ll show you how to create reports that NRapid will execute into an unattended mode. I strongly recommend using this kind of reports in automation scenarios only , and let the user see the print preview dialog in the rest of cases. The only difference between this reports and the standard ones, is that you will cannot make use of dialogs, the runtime will always pass in empty views to the ConfigureReport method. The ConfigureReport method will be executed, but you will have to grab the arguments from somewhere else. The execution pipeline is the same that NRapid uses for standard reports. This is the code to print out the whole list of categories in a dialogless mode. Notice that this report inherits from UnattendedReport class, this class tells to NRapid “run the report unattended”. Also notice that this class comes with a convenience method to configure the report with no arguments. You still can override the one that gets the view data but you will always

How to show excel files inside the .NET Webbrowser Control

If you are reading this, chances are you been banging your head against the wall for a couple of hours (or even days) trying to show excel files inside the WinForms webbrowser control. Possible reasons you ended up in here: You had working code that got broke after upgrading from Win 7. Your code doesn’t work the same way between machines running different (newer) versions of IE. A download box pops up every time your app tries to show an excel file inside the webbrowser control (you wanna show the actual content). You just have no clue on how to get excel working into the .NET embedded webbrowser control. You are trying to implement IInternetSecurityManager and don’t know where to start. (Or how don’t know how to delegate calls to your security manager). Among many other, maybe….. Yes, COM is a PITA, so is ActiveX and IE (Embedded or full for that matter). And no, showing excel files inside the webbrowser control shouldn’t be that hard, but sometimes we have